Conversation
Coverage Report
|
markmur
force-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
cf86f99 to
8cc1718
Compare
markmur
force-pushed
the
markmur/replace-react-test-renderer
branch
from
8cc1718 to
c029d80
Compare
package.json
Outdated
| "react-native-gesture-handler": "^2.15.0", | ||
| "react-native-gradle-plugin": "^0.71.19", | ||
| "react-test-renderer": "18.3.1", | ||
| "react-test-renderer": "18.2.0", |
There was a problem hiding this comment.
as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?
There was a problem hiding this comment.
@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59
There was a problem hiding this comment.
ah my bad I always end up on the wrong docs page for @testing-library/react-native
- https://testing-library.com/docs/react-native-testing-library/intro <- doesn't mention adding react-test-renderer
- https://callstack.github.io/react-native-testing-library/docs/start/quick-start <- calls out adding react-test-renderer dep
Useful to know - its marked as deprecated from react-native 77 / React19
Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705
There was a problem hiding this comment.
Interesting, looks like they're replacing it with a universal-test-renderer package
markmur
force-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
2ca9d57 to
c23c7bf
Compare
markmur
force-pushed
the
markmur/replace-react-test-renderer
branch
from
c23c7bf to
04ce4c4
Compare
markmur
force-pushed
the
markmur/replace-react-test-renderer
branch
from
04ce4c4 to
4d360b7
Compare
kieran-osgood-shopify
left a comment
kieran-osgood-shopify
left a comment
There was a problem hiding this comment.
Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0
reduces the amount of changes needed to maintain / experiment with queries
2 participants
What changes are you making?
Adds
@testing-library/react-nativeand updates the context tests.PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.